Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

workaround for giflib >=5.2 #1248

Merged
merged 3 commits into from
Jul 23, 2024
Merged

workaround for giflib >=5.2 #1248

merged 3 commits into from
Jul 23, 2024

Conversation

yaito3014
Copy link
Contributor

No description provided.

@yaito3014 yaito3014 changed the title const-qualify input pointers workaround for giflib >=5.2 Jul 20, 2024
@Reputeless
Copy link
Member

プルリクエストありがとうございます。
のちの開発者の理解のために、この変更がどのような問題をなぜ解決するか、説明の記述をお願いします。

@yaito3014
Copy link
Contributor Author

Debian による giflib に対するパッチで GifQuantizeBuffer のプロトタイプ宣言が変更されており、 Ubuntu の giflib 5.2.2-1 に対して宣言が conflict してエラーとなるため、それを修正します

int 
 GifQuantizeBuffer(unsigned int Width,
 	unsigned int Height,
 	int* ColorMapSize,
- 	GifByteType* RedInput,
- 	GifByteType* GreenInput,
- 	GifByteType* BlueInput
+ 	const GifByteType* RedInput, 
+ 	const GifByteType* GreenInput,
+ 	const GifByteType* BlueInput
 	GifByteType* OutputBuffer,
 	GifColorType* OutputColorMap);

@Reputeless Reputeless changed the base branch from main to v6_develop July 23, 2024 04:06
@Reputeless Reputeless merged commit 53603be into Siv3D:v6_develop Jul 23, 2024
2 checks passed
@Reputeless
Copy link
Member

Merged. Thank you!

@yaito3014 yaito3014 deleted the patch-1 branch July 23, 2024 22:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
v0.6.16
Projects
v0.6 Roadmap
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@yaito3014 @Reputeless